Repository navigation
Conversation
Same as rnmapbox#4205 (comment) RNMBXRasterArraySource now uses tileUrlTemplates instead of uRL, and therefore it should check it contains data to render.
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR updates the Android Mapbox v11-compat implementation of RNMBXRasterArraySource so the “no data, therefore this must refer to an existing source” heuristic accounts for the newer tileUrlTemplates-based configuration (in addition to the legacy uRL property). This aligns RNMBXRasterArraySource behavior with the existing RNMBXRasterSource/RNMBXRasterDemSource logic and prevents raster array sources from being incorrectly treated as “existing” when they actually have template data to render.
Changes:
- Update
RNMBXRasterArraySource.hasNoDataSoRefersToExisting()to considertileUrlTemplates.isEmpty()alongsideuRL == null.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@scharron thanks for the fix, and sorry it took so long to get to it. Could you merge the latest |
Same as #4205 (comment) RNMBXRasterArraySource now uses tileUrlTemplates instead of uRL, and therefore it should check it contains data to render.
Description
Fixes #
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing